# \[patch\] Input: potential info leak in uiput\_ff\_upload\_to\_user()

- Subsystems: INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS, THE REST
- Maintainers: Dmitry Torokhov, Linus Torvalds
- List: linux-input
- 3 messages, 2 authors
- Page: https://ratatoskr.run/linux-input/2011/09/8917809/t

## \[patch\] Input: potential info leak in uiput\_ff\_upload\_to\_user()

- From: Dan Carpenter \<hidden\>
- Date: 2011-09-23 06:23:02 
- Message: https://ratatoskr.run/linux-input/2011/09/8917809.md

```text
Smatch has a new check for Rosenberg type information leaks where
structs are copied to the user with uninitialized stack data in them.

The issue here is that struct uinput_ff_upload_compat has a hole in
it.

struct uinput_ff_upload_compat {
        int                        request_id;           /*     0     4 */
        int                        retval;               /*     4     4 */
        struct ff_effect_compat    effect;               /*     8     0 */

        /* XXX 44 bytes hole, try to pack */

        struct ff_effect_compat    old;                  /*    52     0 */

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 7360568..40e2ba4 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -528,6 +528,8 @@ static int uinput_ff_upload_to_user(char __user *buffer,
 	if (INPUT_COMPAT_TEST) {
 		struct uinput_ff_upload_compat ff_up_compat;
 
+		memset(&ff_up_compat, 0, sizeof(ff_up_compat));
+
 		ff_up_compat.request_id = ff_up->request_id;
 		ff_up_compat.retval = ff_up->retval;
 		/*
```

## Re: \[patch\] Input: potential info leak in uiput\_ff\_upload\_to\_user()

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2011-09-23 07:30:46 
- Message: https://ratatoskr.run/linux-input/2011/09/8917812.md

```text
On Fri, Sep 23, 2011 at 09:22:40AM +0300, Dan Carpenter wrote:
> Smatch has a new check for Rosenberg type information leaks where
> structs are copied to the user with uninitialized stack data in them.
> 
> The issue here is that struct uinput_ff_upload_compat has a hole in
> it.
> 
> struct uinput_ff_upload_compat {
>         int                        request_id;           /*     0     4 */
>         int                        retval;               /*     4     4 */
>         struct ff_effect_compat    effect;               /*     8     0 */
> 
>         /* XXX 44 bytes hole, try to pack */
> 
>         struct ff_effect_compat    old;                  /*    52     0 */


44 bytes... doubtful...

Thanks.

-- 
Dmitry
```

## Re: \[patch\] Input: potential info leak in uiput\_ff\_upload\_to\_user()

- From: Dan Carpenter \<hidden\>
- Date: 2011-09-23 07:34:37 
- Message: https://ratatoskr.run/linux-input/2011/09/8917814.md

```text
This one is wrong as well.  I suck.  :/

regards,
dan carpenter
```
