# Re: \[PATCH 1/2\] Input: wacom\_w8001 - implement open and close

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2011-08-23 17:48:37 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2011/08/8917569
- Thread: https://ratatoskr.run/linux-input/2011/08/8917551/t.md

```text
On Tue, Aug 23, 2011 at 12:22:06PM -0500, Chris Bagwell wrote:
> I don't have one of these to test but anyways:
> 
> Acked-by: Chris Bagwell <redacted>

Thanks for looking at this. I don't have the hardware either so it would
be nice if someone who has it tried the patches...

> 
> I've been trying to slowing document the protocols for ISDV4 and USB
> Wacom devices (http://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=ISDV4_Protocol
> for these ISDV4 ones if your interested).  During this, I was
> comparing this version against the user land version of this driver
> inside xf86-input-wacom.
> 
> xf86-input-wacom was doing a version of this patch so good to see
> here.  The only other difference remaining is it also discards any
> data on the line during startup to flush old data from after initial
> STOP command and so that its sure of command/response sequence.

Hmm, I guess it indeed would be a good idea to reset w8001->idx in
w8001_open() to make sure we do not restart with buffer half-filled with
old data...

Thanks.

-- 
Dmitry
```
