[patch 2/2 -next] hid-lg4ff: add a kfree() to an error path
DORMANTno replies
From: Dan Carpenter <hidden>
Date: 2011-08-18 13:45:56
Also in:
kernel-janitors
Subsystem:
hid core layer, the rest · Maintainers:
Jiri Kosina, Benjamin Tissoires, Linus Torvalds
There is a small rare potential memory leak here. But it's easy to fix. Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index dc38c2d..2b4bbcb 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c@@ -438,6 +438,7 @@ int lg4ff_init(struct hid_device *hid) entry->device_id = (char *)kzalloc(strlen((&hid->dev)->kobj.name) + 1, GFP_KERNEL); if (!entry->device_id) { hid_err(hid, "Cannot set device_id, insufficient memory.\n"); + kfree(entry); return -ENOMEM; } strcpy(entry->device_id, (&hid->dev)->kobj.name);