[PATCH 2/2] HID: kfree() NULL pointer cleanup

Subsystems: hid core layer, the rest

STALE5493d

2 messages, 2 authors, 2011-08-04 · open the first message on its own page

[PATCH 2/2] HID: kfree() NULL pointer cleanup

From: Bojan Prtvar <hidden>
Date: 2011-08-04 20:44:07 

Checking for NULL pointers before kfree() is redundant.

Signed-off-by: Bojan Prtvar <redacted>
---
 drivers/hid/hid-zydacron.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c
index e903715..1ad85f2 100644
--- a/drivers/hid/hid-zydacron.c
+++ b/drivers/hid/hid-zydacron.c
@@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev)
 	struct zc_device *zc = hid_get_drvdata(hdev);
 
 	hid_hw_stop(hdev);
-
-	if (NULL != zc)
-		kfree(zc);
+	kfree(zc);
 }
 
 static const struct hid_device_id zc_devices[] = {
-- 
1.7.1

Re: [PATCH 2/2] HID: kfree() NULL pointer cleanup

From: Jiri Kosina <hidden>
Date: 2011-08-04 21:47:05 

On Thu, 4 Aug 2011, Bojan Prtvar wrote:
quoted hunk
Checking for NULL pointers before kfree() is redundant.

Signed-off-by: Bojan Prtvar <redacted>
---
 drivers/hid/hid-zydacron.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c
index e903715..1ad85f2 100644
--- a/drivers/hid/hid-zydacron.c
+++ b/drivers/hid/hid-zydacron.c
@@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev)
 	struct zc_device *zc = hid_get_drvdata(hdev);
 
 	hid_hw_stop(hdev);
-
-	if (NULL != zc)
-		kfree(zc);
+	kfree(zc);
 }
Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help