# \[PATCH\] Input: gpio\_keys - Return proper error code

- Subsystems: INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS, THE REST
- Maintainers: Dmitry Torokhov, Linus Torvalds
- List: linux-input
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-input/2011/07/8917320/t

## \[PATCH\] Input: gpio\_keys - Return proper error code

- From: Tobias Klauser \<tklauser@distanz.ch\>
- Date: 2011-07-27 09:20:05 
- Message: https://ratatoskr.run/linux-input/2011/07/8917320.md

```text
Return -ENOMEM if kzalloc fails in gpio_keys_get_devtree_pdata.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/input/keyboard/gpio_keys.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index ce281d1..67df91a 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -483,7 +483,7 @@ static int gpio_keys_get_devtree_pdata(struct device *dev,
 
 	buttons = kzalloc(pdata->nbuttons * (sizeof *buttons), GFP_KERNEL);
 	if (!buttons)
-		return -ENODEV;
+		return -ENOMEM;
 
 	pp = NULL;
 	i = 0;
-- 
1.7.5.4

```

## Re: \[PATCH\] Input: gpio\_keys - Return proper error code

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2011-07-30 19:08:34 
- Message: https://ratatoskr.run/linux-input/2011/07/8917373.md

```text
On Wed, Jul 27, 2011 at 11:10:47AM +0200, Tobias Klauser wrote:
> Return -ENOMEM if kzalloc fails in gpio_keys_get_devtree_pdata.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Applied, thanks Tobias.

-- 
Dmitry
```
