[PATCH] drivers:input:free the memory before set it to NULL

The memory of the platform driver data should be freed
before it was set to NULL.

Signed-off-by: Wanlong Gao <redacted>
---
 drivers/input/misc/pmic8xxx-pwrkey.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c
index b3cfb9c..2f3ca73 100644
--- a/drivers/input/misc/pmic8xxx-pwrkey.c
+++ b/drivers/input/misc/pmic8xxx-pwrkey.c

@@ -198,8 +198,8 @@ static int __devexit pmic8xxx_pwrkey_remove(struct platform_device *pdev)
 	free_irq(key_press_irq, pwrkey);
 	free_irq(key_release_irq, pwrkey);
 	input_unregister_device(pwrkey->pwr);
-	platform_set_drvdata(pdev, NULL);
 	kfree(pwrkey);
+	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }

-- 
1.7.4.1

On Wed, 20 Jul 2011 23:41:36 +0800
Wanlong Gao [off-list ref] wrote:

The memory of the platform driver data should be freed
before it was set to NULL.

This seems backwards to me. Currently the reference is invalidated before
the object, which seems to make more sense.

As there is no locking here it really makes no difference anyway

On 三, 2011-07-20 at 16:54 +0100, Alan Cox wrote:

On Wed, 20 Jul 2011 23:41:36 +0800
Wanlong Gao [off-list ref] wrote:

quoted

The memory of the platform driver data should be freed
before it was set to NULL.

This seems backwards to me. Currently the reference is invalidated before
the object, which seems to make more sense.

As there is no locking here it really makes no difference anyway

Hmm...
FYI, I see it. Thanks Alan.
And sorry for making noise.

Wanlong Gao

quoted

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On 三, 2011-07-20 at 16:54 +0100, Alan Cox wrote:

On Wed, 20 Jul 2011 23:41:36 +0800
Wanlong Gao [off-list ref] wrote:

quoted

The memory of the platform driver data should be freed
before it was set to NULL.

This seems backwards to me. Currently the reference is invalidated before
the object, which seems to make more sense.

As there is no locking here it really makes no difference anyway

BTW, your email head icon is so cool.

Thanks
Wanlong Gao

quoted

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html