[PATCH 3/3] Input: atmel_mxt_ts - Handle objects with multiple instances correctly

Subsystems: atmel maxtouch driver, input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE5536d

2 messages, 2 authors, 2011-07-04 · open the first message on its own page

[PATCH 3/3] Input: atmel_mxt_ts - Handle objects with multiple instances correctly

From: Iiro Valkonen <hidden>
Date: 2011-07-04 09:06:47

Handle the objects with multiple instances correctly when the configuration data
is loaded.

Signed-off-by: Iiro Valkonen <redacted>
---
 drivers/input/touchscreen/atmel_mxt_ts.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index da8c9ca..90f221f 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -655,7 +655,9 @@ static int mxt_check_reg_init(struct mxt_data *data)
 		if (!mxt_object_writable(object->type))
 			continue;
 
-		for (j = 0; j < object->size + 1; j++) {
+		for (j = 0;
+		     j < ((object->size + 1) * (object->instances + 1));
+		     j++) {
 			config_offset = index + j;
 			if (config_offset > pdata->config_length) {
 				dev_err(dev, "Not enough config data!\n");
@@ -664,7 +666,7 @@ static int mxt_check_reg_init(struct mxt_data *data)
 			mxt_write_object(data, object->type, j,
 					 pdata->config[config_offset]);
 		}
-		index += object->size + 1;
+		index += (object->size + 1) * (object->instances + 1);
 	}
 
 	return 0;
-- 
1.7.0.4

Re: [PATCH 3/3] Input: atmel_mxt_ts - Handle objects with multiple instances correctly

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-07-04 10:18:07

On Mon, Jul 04, 2011 at 12:06:31PM +0300, Iiro Valkonen wrote:
Handle the objects with multiple instances correctly when the configuration data
is loaded.

Signed-off-by: Iiro Valkonen <redacted>
Applied, thanks Iiro.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help