[PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level

STALE5540d

2 messages, 2 authors, 2011-07-04 · open the first message on its own page

[PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level

From: Ping Cheng <hidden>
Date: 2011-07-01 15:58:23

On Thu, Jun 30, 2011 at 10:18 PM, Henrik Rydberg [off-list ref] wrote:

    > Hi Ping,

    > On Fri, Jun 24, 2011 at 05:14:58PM -0700, Ping Cheng wrote:
    >> Instead of 512.
    >>
    >> Reported-by: David Foley [off-list ref]
    >> Signed-off-by: Ping Cheng [off-list ref]
    >> ---

    > Perhaps one could elaborate the commit message a bit - in particular
    > since the text mentions 512, whereas the patch seems to change from
    > 256?

Nice catch, Henrik. 512 was a typo. Does this commit message work:

It is reported by Ubuntu users that Wacom Bamboo Pen D4 has 1024
pressure level instead of 256.

Ping

    >>  drivers/input/tablet/wacom_wac.c |    2 +-
    >>  1 files changed, 1 insertions(+), 1 deletions(-)
    >>
    >> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
    >> index 2ea0d2e..1cbb9a8 100644
    >> --- a/drivers/input/tablet/wacom_wac.c
    >> +++ b/drivers/input/tablet/wacom_wac.c
    >> @@ -1462,7 +1462,7 @@ static const struct wacom_features wacom_features_0xD3 =
    >>       { "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023,
    >>         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
    >>  static const struct wacom_features wacom_features_0xD4 =
    >> -     { "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200,  255,
    >> +     { "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
    >>         63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
    >>  static const struct wacom_features wacom_features_0xD6 =
    >>       { "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN,   14720,  9200, 1023,
    >> --
    > 
    > Thanks,
    > Henrik 

Re: [PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-07-04 10:21:05

On Fri, Jul 01, 2011 at 08:59:51AM -0700, Ping Cheng wrote:
On Thu, Jun 30, 2011 at 10:18 PM, Henrik Rydberg [off-list ref] wrote:

    > Hi Ping,

    > On Fri, Jun 24, 2011 at 05:14:58PM -0700, Ping Cheng wrote:
    >> Instead of 512.
    >>
    >> Reported-by: David Foley [off-list ref]
    >> Signed-off-by: Ping Cheng [off-list ref]
    >> ---

    > Perhaps one could elaborate the commit message a bit - in particular
    > since the text mentions 512, whereas the patch seems to change from
    > 256?

Nice catch, Henrik. 512 was a typo. Does this commit message work:

It is reported by Ubuntu users that Wacom Bamboo Pen D4 has 1024
pressure level instead of 256.
Unfortunately I already pushed out the patch to we'll have to live with
bad log message. Oh well...

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help