[PATCH] input: xilinx_ps2: Add missing of_address.h header

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE5516d

5 messages, 3 authors, 2011-08-01 · open the first message on its own page

[PATCH] input: xilinx_ps2: Add missing of_address.h header

From: Michal Simek <monstr@monstr.eu>
Date: 2011-07-13 13:46:28

Add missing header.

Error log:
CC      drivers/input/serio/xilinx_ps2.o
drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'

Signed-off-by: Michal Simek <monstr@monstr.eu>
---
 drivers/input/serio/xilinx_ps2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
index 80baa53..d64c5a4 100644
--- a/drivers/input/serio/xilinx_ps2.c
+++ b/drivers/input/serio/xilinx_ps2.c
@@ -23,7 +23,7 @@
 #include <linux/init.h>
 #include <linux/list.h>
 #include <linux/io.h>
-
+#include <linux/of_address.h>
 #include <linux/of_device.h>
 #include <linux/of_platform.h>
 
-- 
1.5.5.6

Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header

From: Grant Likely <hidden>
Date: 2011-07-13 15:27:34

On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek [off-list ref] wrote:
Add missing header.

Error log:
CC      drivers/input/serio/xilinx_ps2.o
drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'

Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: Grant Likely <redacted>
quoted hunk
---
 drivers/input/serio/xilinx_ps2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
index 80baa53..d64c5a4 100644
--- a/drivers/input/serio/xilinx_ps2.c
+++ b/drivers/input/serio/xilinx_ps2.c
@@ -23,7 +23,7 @@
 #include <linux/init.h>
 #include <linux/list.h>
 #include <linux/io.h>
-
+#include <linux/of_address.h>
 #include <linux/of_device.h>
 #include <linux/of_platform.h>

--
1.5.5.6


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header

From: Michal Simek <monstr@monstr.eu>
Date: 2011-07-24 13:51:41

Hi Grant,

can you propose this patch to mainline through your devicetree tree?

Thanks,
Michal

Grant Likely wrote:
On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek [off-list ref] wrote:
quoted
Add missing header.

Error log:
CC      drivers/input/serio/xilinx_ps2.o
drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'

Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: Grant Likely <redacted>
quoted
---
 drivers/input/serio/xilinx_ps2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
index 80baa53..d64c5a4 100644
--- a/drivers/input/serio/xilinx_ps2.c
+++ b/drivers/input/serio/xilinx_ps2.c
@@ -23,7 +23,7 @@
 #include <linux/init.h>
 #include <linux/list.h>
 #include <linux/io.h>
-
+#include <linux/of_address.h>
 #include <linux/of_device.h>
 #include <linux/of_platform.h>

--
1.5.5.6

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header

From: Grant Likely <hidden>
Date: 2011-07-31 14:26:38

On Sun, Jul 24, 2011 at 03:51:30PM +0200, Michal Simek wrote:
Hi Grant,

can you propose this patch to mainline through your devicetree tree?
I've got it in a "input/next" branch.  Since the input maintainer
doesn't seem to be active on driver patches, I'll send a pull req to
Linus.

g.
Thanks,
Michal

Grant Likely wrote:
quoted
On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek [off-list ref] wrote:
quoted
Add missing header.

Error log:
CC      drivers/input/serio/xilinx_ps2.o
drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'

Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: Grant Likely <redacted>
quoted
---
drivers/input/serio/xilinx_ps2.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
index 80baa53..d64c5a4 100644
--- a/drivers/input/serio/xilinx_ps2.c
+++ b/drivers/input/serio/xilinx_ps2.c
@@ -23,7 +23,7 @@
#include <linux/init.h>
#include <linux/list.h>
#include <linux/io.h>
-
+#include <linux/of_address.h>
#include <linux/of_device.h>
#include <linux/of_platform.h>

--
1.5.5.6

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-08-01 03:10:31

On Sat, Jul 30, 2011 at 10:12:30PM -0600, Grant Likely wrote:
On Sun, Jul 24, 2011 at 03:51:30PM +0200, Michal Simek wrote:
quoted
Hi Grant,

can you propose this patch to mainline through your devicetree tree?
I've got it in a "input/next" branch.  Since the input maintainer
doesn't seem to be active on driver patches, I'll send a pull req to
Linus.
CCing me on patches usually helps... Yes, please feel free to push
through your tree if you'd like.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help