Thread (7 messages) 7 messages, 3 authors, 2011-05-17

Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations

From: Russell King - ARM Linux <hidden>
Date: 2011-05-15 10:59:10
Also in: linux-arm-msm, linux-i2c, lkml

On Sun, May 15, 2011 at 01:00:31AM -0700, Dmitry Torokhov wrote:
On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote:
quoted
For chip drivers that support both pwm and non-pwm modes
would encounter compilation errors if the platform doesn't
have support for pwm though the chip is programmed to work
in non-pwm mode. Add __weak attributed pwm functions to avoid
compilation issues in these scenarios.
Russell,

You seem to have authored pwm.h, do you have any objections to this
change?
This seems to be a recipe for an oops.  Have a look at how
linux/regulator/consumer.h deals with this kind of problem, and notice
that we have CONFIG_HAVE_PWM to indicate whether this interface is
supported or not.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help