The ads7846 driver requests a gpio to detect pendown events,
but does not configure its direction. Configure this gpio
as an input after requesting it.
Signed-off-by: Sourav Poddar <redacted>
---
changes between v2 and v1: Added return error support in v2.
drivers/input/touchscreen/ads7846.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
From: Felipe Balbi <hidden> Date: 2011-02-03 09:58:45
On Thu, Feb 03, 2011 at 03:18:50PM +0530, Sourav Poddar wrote:
quoted hunk
The ads7846 driver requests a gpio to detect pendown events,
but does not configure its direction. Configure this gpio
as an input after requesting it.
Signed-off-by: Sourav Poddar <redacted>
---
changes between v2 and v1: Added return error support in v2.
drivers/input/touchscreen/ads7846.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
Sourav,
On Thu, Feb 3, 2011 at 15:28, Felipe Balbi [off-list ref] wrote:
On Thu, Feb 03, 2011 at 03:18:50PM +0530, Sourav Poddar wrote:
quoted
The ads7846 driver requests a gpio to detect pendown events,
but does not configure its direction. Configure this gpio
as an input after requesting it.
Signed-off-by: Sourav Poddar <redacted>
---
changes between v2 and v1: Added return error support in v2.
drivers/input/touchscreen/ads7846.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
return err;
}
+ err = gpio_direction_input(pdata->gpio_pendown);
+ if (err) {
+ dev_err(&spi->dev, "failed to configure pendown GPIO input direction %d\n",
+ pdata->gpio_pendown);
+ return err;
and now you miss a gpio_free().
My question to your previous version is still unanswered.
Would it be relevant to add gpio_set_debounce() for this
gpio?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Wolfram Sang <hidden> Date: 2011-02-03 10:10:33
On Thu, Feb 03, 2011 at 11:58:45AM +0200, Felipe Balbi wrote:
On Thu, Feb 03, 2011 at 03:18:50PM +0530, Sourav Poddar wrote:
quoted
The ads7846 driver requests a gpio to detect pendown events,
but does not configure its direction. Configure this gpio
as an input after requesting it.
Signed-off-by: Sourav Poddar <redacted>
---
changes between v2 and v1: Added return error support in v2.
drivers/input/touchscreen/ads7846.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
From: Felipe Balbi <hidden> Date: 2011-02-03 10:22:42
On Thu, Feb 03, 2011 at 11:10:33AM +0100, Wolfram Sang wrote:
On Thu, Feb 03, 2011 at 11:58:45AM +0200, Felipe Balbi wrote:
quoted
On Thu, Feb 03, 2011 at 03:18:50PM +0530, Sourav Poddar wrote:
quoted
The ads7846 driver requests a gpio to detect pendown events,
but does not configure its direction. Configure this gpio
as an input after requesting it.
Signed-off-by: Sourav Poddar <redacted>
---
changes between v2 and v1: Added return error support in v2.
drivers/input/touchscreen/ads7846.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
On Thu, Feb 3, 2011 at 3:40 PM, Wolfram Sang [off-list ref] wrote:
On Thu, Feb 03, 2011 at 11:58:45AM +0200, Felipe Balbi wrote:
quoted
On Thu, Feb 03, 2011 at 03:18:50PM +0530, Sourav Poddar wrote:
quoted
The ads7846 driver requests a gpio to detect pendown events,
but does not configure its direction. Configure this gpio
as an input after requesting it.
Signed-off-by: Sourav Poddar <redacted>
---
changes between v2 and v1: Added return error support in v2.
drivers/input/touchscreen/ads7846.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
return err;
}
+ err = gpio_direction_input(pdata->gpio_pendown);
+ if (err) {
+ dev_err(&spi->dev, "failed to configure pendown GPIO input direction %d\n",
+ pdata->gpio_pendown);
+ return err;
and now you miss a gpio_free().
Better use gpio_request_one()?
Totally agreed,using gpio_request_one seems to be the better option.
Will post a patch for it.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 3, 2011 at 3:34 PM, Varadarajan, Charulatha [off-list ref] wrote:
Sourav,
On Thu, Feb 3, 2011 at 15:28, Felipe Balbi [off-list ref] wrote:
quoted
On Thu, Feb 03, 2011 at 03:18:50PM +0530, Sourav Poddar wrote:
quoted
The ads7846 driver requests a gpio to detect pendown events,
but does not configure its direction. Configure this gpio
as an input after requesting it.
Signed-off-by: Sourav Poddar <redacted>
---
changes between v2 and v1: Added return error support in v2.
drivers/input/touchscreen/ads7846.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
return err;
}
+ err = gpio_direction_input(pdata->gpio_pendown);
+ if (err) {
+ dev_err(&spi->dev, "failed to configure pendown GPIO input direction %d\n",
+ pdata->gpio_pendown);
+ return err;
and now you miss a gpio_free().
My question to your previous version is still unanswered.
Would it be relevant to add gpio_set_debounce() for this
gpio?
I was also wondering that.I too think that just a request and then an
configuring direction would do.But,I am not so sure about this one.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html