On Thu, 19 Aug 2010, Steffen Barszus wrote:
Any chance someone can have a look or is something missing ? Is this the wrong place ? Or just bad timing because of the
merge window ? Would love to see this incorporated.
Hi,
I haven't been CCed on your original mail, was I?
Anyway, would you be able to send the patch properly to me, so that I
could apply it? (i.e. not line-wrapped and whitespace damaged, with proper
Signed-off-by line, etc -- see Documentation/SubmittingPatches if in
doubt).
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
On Fri, 20 Aug 2010 11:12:18 +0200 (CEST)
Jiri Kosina [off-list ref] wrote:
On Thu, 19 Aug 2010, Steffen Barszus wrote:
quoted
Any chance someone can have a look or is something missing ? Is
this the wrong place ? Or just bad timing because of the merge
window ? Would love to see this incorporated.
Hi,
I haven't been CCed on your original mail, was I?
No
Anyway, would you be able to send the patch properly to me, so that I
could apply it? (i.e. not line-wrapped and whitespace damaged, with
proper Signed-off-by line, etc -- see Documentation/SubmittingPatches
if in doubt).
Hope this time its correct. Please let me know if you miss something.
Thanks,
Signed-off-by: Steffen Barszus <steffenbpunkt[AT]googlemail[DOT]com>
--- linux-2.6/drivers/hid/hid-gyration.c.orig 2010-09-13 08:16:36.353369149 +0200
+++ linux-2.6/drivers/hid/hid-gyration.c 2010-09-13 08:17:56.629965460 +0200
@@ -43,6 +43,11 @@ static int gyration_input_mapping(struct
case 0x048: gy_map_key_clear(KEY_MEDIA); break;
case 0x049: gy_map_key_clear(KEY_CAMERA); break;
case 0x04a: gy_map_key_clear(KEY_VIDEO); break;
+ case 0x05a: gy_map_key_clear(KEY_TEXT); break;
+ case 0x05b: gy_map_key_clear(KEY_RED); break;
+ case 0x05c: gy_map_key_clear(KEY_GREEN); break;
+ case 0x05d: gy_map_key_clear(KEY_YELLOW); break;
+ case 0x05e: gy_map_key_clear(KEY_BLUE); break;
default:
return 0;
On Mon, 13 Sep 2010, Steffen Barszus wrote:
quoted hunk
quoted
I haven't been CCed on your original mail, was I?
No
quoted
Anyway, would you be able to send the patch properly to me, so that I
could apply it? (i.e. not line-wrapped and whitespace damaged, with
proper Signed-off-by line, etc -- see Documentation/SubmittingPatches
if in doubt).
Hope this time its correct. Please let me know if you miss something.
quoted
Thanks,
Signed-off-by: Steffen Barszus <steffenbpunkt[AT]googlemail[DOT]com>
--- linux-2.6/drivers/hid/hid-gyration.c.orig 2010-09-13 08:16:36.353369149 +0200
+++ linux-2.6/drivers/hid/hid-gyration.c 2010-09-13 08:17:56.629965460 +0200
@@ -43,6 +43,11 @@ static int gyration_input_mapping(struct
case 0x048: gy_map_key_clear(KEY_MEDIA); break;
case 0x049: gy_map_key_clear(KEY_CAMERA); break;
case 0x04a: gy_map_key_clear(KEY_VIDEO); break;
+ case 0x05a: gy_map_key_clear(KEY_TEXT); break;
+ case 0x05b: gy_map_key_clear(KEY_RED); break;
+ case 0x05c: gy_map_key_clear(KEY_GREEN); break;
+ case 0x05d: gy_map_key_clear(KEY_YELLOW); break;
+ case 0x05e: gy_map_key_clear(KEY_BLUE); break;
default:
return 0;
Almost there :) Please also include changelog (short description of what
the patch does, which device contains these keys, etc) together with the
actual patch, so that I could apply it.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.