[PATCH] HID: roccat: Fixing race condition on initialization
From: Stefan Achatz <erazor_de@users.sourceforge.net>
Date: 2010-08-28 12:57:59
Also in:
lkml
Subsystem:
hid core layer, roccat drivers, the rest · Maintainers:
Jiri Kosina, Benjamin Tissoires, Stefan Achatz, Linus Torvalds
Fixed raced condition where event occurs before drvdata is set. Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net> --- drivers/hid/hid-roccat-kone.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
index f776957..cfeab56 100644
--- a/drivers/hid/hid-roccat-kone.c
+++ b/drivers/hid/hid-roccat-kone.c@@ -966,6 +966,10 @@ static int kone_raw_event(struct hid_device *hdev, struct hid_report *report, struct kone_device *kone = hid_get_drvdata(hdev); struct kone_mouse_event *event = (struct kone_mouse_event *)data; + /* possible race condition on initialization */ + if (!kone) + return 0; + /* keyboard events are always processed by default handler */ if (size != sizeof(struct kone_mouse_event)) return 0;
--
1.7.2.2