Re: [PATCH] Generic PS/2 mouse detected on Fujitsu Lifebook B-Series model laptop instead of LBPS/2 Fujitsu Lifebook TouchScreen
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2010-01-27 23:55:23
Also in:
lkml
(suitable cc's added) On Mon, 25 Jan 2010 16:12:43 +0000 jon - [off-list ref] wrote:
quoted hunk
From: Jon Dodgson <redacted> Fix Detection of Lifebook B-Series Laptop touch screen with DMI product Name string 'Lifebook B Series' Signed-off-by: Jon Dodgson <redacted> --- diff -Nurb linux-2.6.26.2/drivers/input/mouse/lifebook.c linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c--- linux-2.6.26.2/drivers/input/mouse/lifebook.c 2008-08-0617:19:01.000000000 +0100+++ linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c 2010-01-2502:56:41.000000000 +0000@@ -51,6 +51,12 @@ { .ident = "LifeBook B", .matches = { + DMI_MATCH(DMI_PRODUCT_NAME, "Lifebook B Series"), + }, + }, + { + .ident = "LifeBook B", + .matches = { DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook B Series"), }, },
So the problem is "LifeBook" versus "Lifebook"? These matches are case-sensitive? I don't know what kernel you were patching, but current kernels no longer have the ".ident" initialisation in that table. If it _was_ still there then I'd wonder why you set the ident to "LifeBook B" rather than "Lifebook B". Your email client wordwrapped the patch and replaced its tabs with spaces. Anyway, thanks. Please work this with Dmitry.