[PATCH] input/keyboard/hilkbd.c: fix crash when removing hilkbd module

STALE6441d

2 messages, 2 authors, 2008-12-27 · open the first message on its own page

[PATCH] input/keyboard/hilkbd.c: fix crash when removing hilkbd module

From: Helge Deller <deller@gmx.de>
Date: 2008-12-26 19:52:57

On parisc machines, which don't have HIL, removing the hilkbd module
panics the kernel. Fix this by adding proper implementations for the
probe and remove functions to the parisc_driver structure.

A few functions were renamed to clean up the code and make it easier
readable.

Disable the MODULE_DEVICE_TABLE() macro on parisc since the kernel
module autoloader should instead prefer the hp_sdc driver which takes
care of full HIL support, including HIL mouse and HIL tablets.

Signed-off-by: Helge Deller <deller@gmx.de>
CC: Geert Uytterhoeven <geert@linux-m68k.org>

Re: [PATCH] input/keyboard/hilkbd.c: fix crash when removing hilkbd module

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2008-12-27 17:47:39

On Fri, 26 Dec 2008, Helge Deller wrote:
On parisc machines, which don't have HIL, removing the hilkbd module
panics the kernel. Fix this by adding proper implementations for the
probe and remove functions to the parisc_driver structure.

A few functions were renamed to clean up the code and make it easier
readable.

Disable the MODULE_DEVICE_TABLE() macro on parisc since the kernel
module autoloader should instead prefer the hp_sdc driver which takes
care of full HIL support, including HIL mouse and HIL tablets.

Signed-off-by: Helge Deller <deller@gmx.de>
CC: Geert Uytterhoeven <geert@linux-m68k.org>
Looks OK, and still compiles fine on m68k/HP300.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help