From: Mark Brown <hidden> Date: 2008-07-24 13:15:24
Currently the support for each WM97xx touchscreen model is compiled out
by default, meaning that the default configuration when the driver is
built is for it to support no hardware. This is suboptimal and leads to
problems like distribution kernels shipping a non-functional driver.
Change the default to support all controllers and update the help text
to reflect this.
Signed-off-by: Mark Brown <redacted>
---
drivers/input/touchscreen/Kconfig | 21 +++++++++------------
1 files changed, 9 insertions(+), 12 deletions(-)
From: Mark Brown <hidden> Date: 2008-07-24 13:41:20
Currently the support for each WM97xx touchscreen model is compiled out
by default, meaning that the default configuration when the driver is
built is for it to support no hardware. This is suboptimal and leads to
problems like distribution kernels shipping a non-functional driver.
Change the default to support all controllers and update the help text
to reflect this.
Signed-off-by: Mark Brown <redacted>
---
Resubmit, after proofreading.
drivers/input/touchscreen/Kconfig | 21 +++++++++------------
1 files changed, 9 insertions(+), 12 deletions(-)
From: pHilipp Zabel <hidden> Date: 2008-07-24 13:44:32
On Thu, Jul 24, 2008 at 3:15 PM, Mark Brown
[off-list ref] wrote:
quoted hunk
Currently the support for each WM97xx touchscreen model is compiled out
by default, meaning that the default configuration when the driver is
built is for it to support no hardware. This is suboptimal and leads to
problems like distribution kernels shipping a non-functional driver.
Change the default to support all controllers and update the help text
to reflect this.
Signed-off-by: Mark Brown <redacted>
---
drivers/input/touchscreen/Kconfig | 21 +++++++++------------
1 files changed, 9 insertions(+), 12 deletions(-)
+ WM9705 touchscreen controller. config TOUCHSCREEN_WM9712 bool "WM9712 Touchscreen interface support" depends on TOUCHSCREEN_WM97XX+ default y help- Say Y here if you have a Wolfson Microelectronics WM9712- touchscreen controller connected to your system.-- If unsure, say N.+ Say Y here if to enable support for the Wolfson Microelectronics
dito
quoted hunk
+ WM9712 touchscreen controller. config TOUCHSCREEN_WM9713 bool "WM9713 Touchscreen interface support" depends on TOUCHSCREEN_WM97XX+ default y help- Say Y here if you have a Wolfson Microelectronics WM9713 touchscreen- controller connected to your system.-- If unsure, say N.+ Say Y here if to enable support for the Wolfson Microelectronics
dito
+ WM9713 touchscreen controller.
config TOUCHSCREEN_WM97XX_MAINSTONE
tristate "WM97xx Mainstone accelerated touch"
--
1.5.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Arjan van de Ven <hidden> Date: 2008-07-24 13:58:24
On Thu, 24 Jul 2008 14:41:07 +0100
Mark Brown [off-list ref] wrote:
Currently the support for each WM97xx touchscreen model is compiled
out by default, meaning that the default configuration when the
driver is built is for it to support no hardware. This is suboptimal
and leads to problems like distribution kernels shipping a
non-functional driver.
this isn't normally how things are done; Linux is on a "off unless
selected or unless it breaks booting" policy nowadays...
(and distributions don't follow "default" anyway, so don't worry about
that part)
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
From: Mark Brown <hidden> Date: 2008-07-24 14:27:01
On Thu, Jul 24, 2008 at 06:57:56AM -0700, Arjan van de Ven wrote:
Mark Brown [off-list ref] wrote:
quoted
Currently the support for each WM97xx touchscreen model is compiled
out by default, meaning that the default configuration when the
this isn't normally how things are done; Linux is on a "off unless
selected or unless it breaks booting" policy nowadays...
These options only be visible if the user has chosen to build the WM97xx
touchscreen driver which does the default thing already. Within the
context of the driver these options are of the broken boot variety since
without at least one of them being enabled the driver will do nothing
except waste resources.
I really don't think it's sensible for the default configuration of the
driver to produce something totally non-functional.
(and distributions don't follow "default" anyway, so don't worry about
that part)
This change is a direct result of Ubuntu enabling the driver with all
the controllers compiled out. This seems like a completely reasonable
thing for them to do - nothing in Kconfig suggests that it is mandatory
to enable at least one of the options and the existing default and help
text both suggest that it should be turned off.
On Thu, Jul 24, 2008 at 03:26:51PM +0100, Mark Brown wrote:
On Thu, Jul 24, 2008 at 06:57:56AM -0700, Arjan van de Ven wrote:
quoted
Mark Brown [off-list ref] wrote:
quoted
Currently the support for each WM97xx touchscreen model is compiled
out by default, meaning that the default configuration when the
quoted
this isn't normally how things are done; Linux is on a "off unless
selected or unless it breaks booting" policy nowadays...
These options only be visible if the user has chosen to build the WM97xx
touchscreen driver which does the default thing already. Within the
context of the driver these options are of the broken boot variety since
without at least one of them being enabled the driver will do nothing
except waste resources.
I really don't think it's sensible for the default configuration of the
driver to produce something totally non-functional.
quoted
(and distributions don't follow "default" anyway, so don't worry about
that part)
This change is a direct result of Ubuntu enabling the driver with all
the controllers compiled out. This seems like a completely reasonable
thing for them to do - nothing in Kconfig suggests that it is mandatory
to enable at least one of the options and the existing default and help
text both suggest that it should be turned off.
I agree with Mark - since the core driver is disabled by default we
don't burden users who do not want it. However enabling the main
option should produce working driver and people who want to save space
in their custom kernels can disable unneeded sub-options.
Will apply.
--
Dmitry