Hi Dmitry,

Thanks for all your help with this driver.

On Sat, Apr 5, 2008 at 1:14 AM, Dmitry Torokhov
[off-list ref] wrote:

 On Fri, Apr 04, 2008 at 05:21:48PM +0900, Magnus Damm wrote:
 > I just tested using latest sh-2.6 git with evtest. Everything seems to
 > work well. The patch is much cleaner now. Please apply.
 >

 I was just looking the driver over one more time before applying it
 and I think there is a race in migor_ts_remove():

 +       /* cancel pending work and wait for migor_ts_poscheck() to finish */

+       cancel_delayed_work_sync(&priv->work);
 +

 What if interrupt comes here, before we got a chance to shut off the
 device? IRQ is still enabled and it will schedule migor_ts_poscheck()
 again. I think we need to call disable_irq() before canceling the work.
 Since the driver does not support sharing IRQs that should be allright.
 What do you think?

I think you are right. Doing a disable_irq() before canceling the work
sounds good. Can you please add that, or do you want me to fix and
repost?

Thank you!

/ magnus