[patch 2.6.24-rc6-git] gpio_keys minor irq cleanup
DORMANTno replies
From: David Brownell <hidden>
Date: 2007-12-27 20:09:47
From: David Brownell <redacted> Cleanup IRQ handling in gpio_keys: bail after handling the IRQ, and report IRQ_NONE if we never handle it. Signed-off-by: David Brownell <redacted> Cc: Phil Blundell <redacted> Cc: Dmitry Torokhov <redacted> --- grr, not sure why that blank line got removed ... feel free to restore it.
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c@@ -40,13 +40,13 @@ static irqreturn_t gpio_keys_isr(int irq if (irq == gpio_to_irq(gpio)) { unsigned int type = button->type ?: EV_KEY; int state = (gpio_get_value(gpio) ? 1 : 0) ^ button->active_low; - input_event(input, type, button->code, !!state); input_sync(input); + return IRQ_HANDLED; } } - return IRQ_HANDLED; + return IRQ_NONE; } static int __devinit gpio_keys_probe(struct platform_device *pdev)