From: Andreas Herrmann <hidden> Date: 2007-09-18 09:00:33
With LEDS_CLASS=m && JOYSTICK_XPAD_LEDS=y I get following compile error:
...
LD .tmp_vmlinux1
drivers/built-in.o: In function `xpad_disconnect':
xpad.c:(.text+0xb3d6b): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `xpad_probe':
xpad.c:(.text+0xb48a6): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1
...
To avoid this kernel configuration, do auto-select LEDS_CLASS
for JOYSTCK_XPAD_LEDS.
Signed-off-by: Andreas Herrmann <redacted>
---
drivers/input/joystick/Kconfig | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
From: Charles Chambers <hidden> Date: 2007-09-18 17:41:13
<html><div style='background-color:'><DIV class=RTE>
<P>Could somebody please correct the security issue on this server?</P>
<P>I've been getting spam originating on it for almost a year.</P>
<P>The volume is becoming large enough that I'm considering blacklisting the server.</P></DIV></div></html>
On 9/18/07, Charles Chambers [off-list ref] wrote:
Could somebody please correct the security issue on this server?
I've been getting spam originating on it for almost a year.
The volume is becoming large enough that I'm considering blacklisting the
server.
Unsubscribing from the mailing lists you are not interested in is
usually much easier.
--
Dmitry
List-Owner: <mailto:owner-linux-input@atrey.karlin.mff.cuni.cz>
List-Post: <mailto:linux-input@atrey.karlin.mff.cuni.cz>
List-Unsubscribe:
<mailto:linux-input-request@atrey.karlin.mff.cuni.cz?body=unsubscribe>
List-Help: <mailto:majordomo@atrey.karlin.mff.cuni.cz?body=help>
Hi Andreas,
On 9/18/07, Andreas Herrmann [off-list ref] wrote:
With LEDS_CLASS=m && JOYSTICK_XPAD_LEDS=y I get following compile error:
...
LD .tmp_vmlinux1
drivers/built-in.o: In function `xpad_disconnect':
xpad.c:(.text+0xb3d6b): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `xpad_probe':
xpad.c:(.text+0xb48a6): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1
...
To avoid this kernel configuration, do auto-select LEDS_CLASS
for JOYSTCK_XPAD_LEDS.
I'd rather it depend on LEDS_CLASS (but properly). I believe I posted
a patch yesterday.
--
Dmitry
From: Andreas Herrmann <hidden> Date: 2007-09-19 19:16:54
On Tue, Sep 18, 2007 at 01:52:11PM -0400, Dmitry Torokhov wrote:
quoted
To avoid this kernel configuration, do auto-select LEDS_CLASS
for JOYSTCK_XPAD_LEDS.
I'd rather it depend on LEDS_CLASS (but properly). I believe I posted
a patch yesterday.
Didn't see this as I am not subscribed to one of the input or joystick mailing lists
(and didn't find any archive for that lists either).
So today I have checked your input.git tree on git.kernel.org.
Your patch (commit be1945c47248fa9c0a7cf4a04c1f4c32928656d2)
works fine if you rename LED_CLASS to LEDS_CLASS ...
So better fix that typo before your tree is pulled into Linus' tree.
;-)
Thanks and Regards,
Andreas
On 9/19/07, Andreas Herrmann [off-list ref] wrote:
On Tue, Sep 18, 2007 at 01:52:11PM -0400, Dmitry Torokhov wrote:
quoted
quoted
To avoid this kernel configuration, do auto-select LEDS_CLASS
for JOYSTCK_XPAD_LEDS.
I'd rather it depend on LEDS_CLASS (but properly). I believe I posted
a patch yesterday.
Didn't see this as I am not subscribed to one of the input or joystick mailing lists
(and didn't find any archive for that lists either).
So today I have checked your input.git tree on git.kernel.org.
Your patch (commit be1945c47248fa9c0a7cf4a04c1f4c32928656d2)
works fine if you rename LED_CLASS to LEDS_CLASS ...
So better fix that typo before your tree is pulled into Linus' tree.
;-)