These drivers are using iio_poll_func->timestamp in their triggered buffer
handler as the timestamp pushed to buffer. Problem is that it was not set up
at probe time via iio_triggered_buffer_setup(), so timestamp is always 0.
Buffer space has been allocated for the timestamp, so it seems to be
wanted.
These patches make the fix io_triggered_buffer_setup() during probe by
passing the iio_pollfunc_store_time parameter.
Alternative change would be to use iio_get_time_ns() directly in the
push_to_buffers call in the handler. We can do this if you are not
one of those "devices (who) need a timestamp grabbed as soon as possible
after the trigger" (from iio_poll_func definition)
Either way you are using iio_get_tme_ns(), it's just a question of when.
Let me know if you'd rather go the slower way.
Alison Schofield (3):
iio: accel: bma220_spi: set up buffer timestamps for non-zero values
iio: humidity: am2315: set up buffer timestamps for non-zero values
iio: proximity: as3935: set up buffer timestamps for non-zero values
drivers/iio/accel/bma220_spi.c | 2 +-
drivers/iio/humidity/am2315.c | 2 +-
drivers/iio/proximity/as3935.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
2.1.4
From: Breana, Tiberiu A <hidden> Date: 2016-07-11 15:54:07
-----Original Message-----
From: Alison Schofield [mailto:amsfield22@gmail.com]
Sent: Monday, July 11, 2016 6:26 PM
To: jic23@kernel.org
Cc: Breana, Tiberiu A <redacted>; mranostay@gmail.com;
knaack.h@gmx.de; lars@metafoo.de; pmeerw@pmeerw.net; linux-
iio@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] iio: humidity: am2315: set up buffer timestamps for non-
zero values
Use the iio_pollfunc_store_time parameter during triggered buffer set-up to get
valid timestamps.
Signed-off-by: Alison Schofield <redacted>
Cc: Daniel Baluta <redacted>
---
From: Jonathan Cameron <jic23@kernel.org> Date: 2016-07-24 12:05:51
On 11/07/16 16:53, Breana, Tiberiu A wrote:
quoted
-----Original Message-----
From: Alison Schofield [mailto:amsfield22@gmail.com]
Sent: Monday, July 11, 2016 6:25 PM
To: jic23@kernel.org
Cc: Breana, Tiberiu A <redacted>; mranostay@gmail.com;
knaack.h@gmx.de; lars@metafoo.de; pmeerw@pmeerw.net; linux-
iio@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] iio: accel: bma220_spi: set up buffer timestamps for non-
zero values
Use the iio_pollfunc_store_time parameter during triggered buffer set-up to get
valid timestamps.
Signed-off-by: Alison Schofield <redacted>
Cc: Daniel Baluta <redacted>
+1
Reviewed-By: Tiberiu Breana <redacted>
Applied to the fixes-togreg-post-rc1 branch of iio.git
(for my convenience) and marked for stable.
Jonathan
From: Jonathan Cameron <jic23@kernel.org> Date: 2016-07-24 12:07:58
On 11/07/16 16:54, Breana, Tiberiu A wrote:
quoted
-----Original Message-----
From: Alison Schofield [mailto:amsfield22@gmail.com]
Sent: Monday, July 11, 2016 6:26 PM
To: jic23@kernel.org
Cc: Breana, Tiberiu A <redacted>; mranostay@gmail.com;
knaack.h@gmx.de; lars@metafoo.de; pmeerw@pmeerw.net; linux-
iio@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] iio: humidity: am2315: set up buffer timestamps for non-
zero values
Use the iio_pollfunc_store_time parameter during triggered buffer set-up to get
valid timestamps.
Signed-off-by: Alison Schofield <redacted>
Cc: Daniel Baluta <redacted>
---
+1
Reviewed-By: Tiberiu Breana <redacted>
Applied to the fixes-togreg-post-rc1 branch of iio.git and marked for stable.
Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jonathan Cameron <jic23@kernel.org> Date: 2016-07-24 12:09:41
On 11/07/16 16:26, Alison Schofield wrote:
Use the iio_pollfunc_store_time parameter during triggered buffer
set-up to get valid timestamps.
Signed-off-by: Alison Schofield <redacted>
Cc: Daniel Baluta <redacted>
Applied to the fixes-togreg-post-rc1 branch of iio.git and
marked for stable.
Oops to all of these ;)
Jonathan