Re: [PATCH] [PATCH V6]Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices

On Fri, Aug 10, 2012 at 12:29:43AM -0700, anish kumar wrote:

From: anish kumar <redacted>

External connector devices that decides connection information based on
ADC values may use adc-jack device driver. The user simply needs to
provide a table of adc range and connection states. Then, extcon
framework will automatically notify others.

This patch breaks the build:
	ERROR: "extcon_cable_name" [drivers/extcon/extcon-adc-jack.ko] undefined!

And, if you read the comment about extcon_cable_name, it says to not use
it like you are trying to use it.

So, care to fix this up?

thanks,

greg k-h

On Thu, Aug 16, 2012 at 11:10 PM, Greg KH [off-list ref] wrote:

On Fri, Aug 10, 2012 at 12:29:43AM -0700, anish kumar wrote:

quoted

From: anish kumar <redacted>

External connector devices that decides connection information based on
ADC values may use adc-jack device driver. The user simply needs to
provide a table of adc range and connection states. Then, extcon
framework will automatically notify others.

This patch breaks the build:
        ERROR: "extcon_cable_name" [drivers/extcon/extcon-adc-jack.ko] undefined!

And, if you read the comment about extcon_cable_name, it says to not use
it like you are trying to use it.

So, care to fix this up?

Sorry Greg,I was on travel so couldn't fix it up.However soon I will be sending
a patch for this.Looks like we can remove the extcon_cable_name altogether
as it we are anyway getting it from platform data.

thanks,

greg k-h