# Re: \[PATCH\] ata: remove redundant error print in rb532\_pata\_driver\_probe

- From: Sergei Shtylyov \<hidden\>
- Date: 2021-01-14 08:31:04 
- List: linux-ide
- Page: https://ratatoskr.run/linux-ide/2021/01/6234333
- Thread: https://ratatoskr.run/linux-ide/2021/01/6231039/t.md

```text
Hello!

On 13.01.2021 17:04, Menglong Dong wrote:

[...]
>>>        irq = platform_get_irq(pdev, 0);
>>> -     if (irq <= 0) {
>>> -             dev_err(&pdev->dev, "no IRQ resource found\n");
>>> +     if (irq <= 0)
>>>                return -ENOENT;
>>
>>     This still beaks the probe deferral. :-(
>>     But that's another problem...
>>
>> [...]
>>
>> MBR, Sergei
>
> What does this 'MBR' mean? I am a novice~~~

   Generally speaking, Master Boot Record. But I also use it to send you My Best Regards. :-)

> So, is it better to replace 'platform_get_irq' with
> 'platform_get_irq_optional' here?

   No. You should stop overriding the result to -ENOENT and pass the result
up the call chain instead. In order to do it, you should only check for (irq < 0).

> --
>   Best Regards
>   Menglong Dong

MBR, Sergei
```