Thread (11 messages) 11 messages, 5 authors, 2016-10-14

Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default

From: Adam Manzanares <hidden>
Date: 2016-10-13 23:39:12
Also in: linux-block, linux-scsi, lkml

Hello Tejun,

The 10/13/2016 19:22, Tejun Heo wrote:
Hello, Adam.

Sorry about late reply.  Was on vacation.
NP I was on vacation at the end of the week last week.
On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote:
quoted
Add a sysfs entry to turn on priority information being passed
to a ATA device. By default this feature is turned off.

This patch depends on ata: Enabling ATA Command Priorities
Looks generally good but can we please use a device attribute name
which is more specific - ie. enable_ncq_prio?
Will do, I'll also double check the naming scheme of functions and variables 
also. The functions that check if the device has the ncq prio capability might
be too similar to the function that checks if the device attribute is 
enabled.
Thanks.

-- 
tejun
Take care,
Adam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help