I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <redacted>
Signed-off-by: Baole Ni <redacted>
---
drivers/ata/sata_nv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index 734f563..54ef357 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -2511,9 +2511,9 @@ static void nv_adma_host_stop(struct ata_host *host)
module_pci_driver(nv_pci_driver);
-module_param_named(adma, adma_enabled, bool, 0444);
+module_param_named(adma, adma_enabled, bool, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: false)");
-module_param_named(swncq, swncq_enabled, bool, 0444);
+module_param_named(swncq, swncq_enabled, bool, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(swncq, "Enable use of SWNCQ (Default: true)");
-module_param_named(msi, msi_enabled, bool, 0444);
+module_param_named(msi, msi_enabled, bool, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(msi, "Enable use of MSI (Default: false)");
--
2.9.2