# Re: \[PATCH\] ata: hpt366: fix incorrect mask when checking at cmd\_high\_time

- From: One Thousand Gnomes \<hidden\>
- Date: 2016-07-18 20:15:02 
- List: linux-ide
- Page: https://ratatoskr.run/linux-ide/2016/07/4797379
- Thread: https://ratatoskr.run/linux-ide/2016/07/4792802/t.md

```text
On Tue, 12 Jul 2016 12:16:19 +0100
Colin King [ref] wrote:

> From: Colin Ian King <redacted>
> 
> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
> bits 11:8 specify the primary drive cmd_high_time, however,
> currently just 3 bits of the 4 are being used because the mask
> is 0x700 and not 0x0f00.  Fix the mask, allowing for the 40MHz clock
> to be detected.

Is this tested on real hardware ? I learned long ago never to blindly
trust IDE data sheets. It looks right but if anyone actually has a 40MHz
PCI bus box with an HPT366 it would be good to test.

Alan
```