On Wed, Jun 13, 2012 at 7:00 PM, Alan Cox [off-list ref] wrote:

On Wed, 13 Jun 2012 16:03:23 +0800
Lin Ming [off-list ref] wrote:

quoted

On Mon, May 28, 2012 at 5:51 PM, Alan Cox [off-list ref] wrote:

quoted

quoted

+static int is_pci_ata(struct device *dev)
+{
+     struct pci_dev *pdev;
+
+     if (!is_pci_dev(dev))
+             return 0;
+
+     pdev = to_pci_dev(dev);
+
+     if ((pdev->class >> 8) != PCI_CLASS_STORAGE_SATA &&
+         (pdev->class >> 8) != PCI_CLASS_STORAGE_IDE)
+             return 0;

This needs a better name. It doesn't check if a device is PCI ATA or
anything of the sort, it checks if its probably a device in compatibility
mode. A lot of controllers will in fact report RAID class or similar in
native mode.

How about compat_pci_ata?

Sounds reasonable. I'm not btw sure the test is entirely right, but I'm
not sure quite what you are trying to figure out from it and how ACPI
expects this mapping to work.

It's used to figure out if the dev passed in from scsi layer is a ata device.

scsi_sysfs_add_sdev
device_add
acpi_platform_notify
ata_acpi_find_device
is_pci_ata

Thanks,
Lin Ming

Alan