Bugs in kernels 2.6.20 plus 2.6.21 rc1 and 2

2 messages, 2 authors, 2007-03-09 · open the first message on its own page

Bugs in kernels 2.6.20 plus 2.6.21 rc1 and 2

From: Uwe Bugla <hidden>
Date: 2007-03-09 14:09:16

Hello Bart, hello everybody,

As requested I applied the following patch with parameter -R against 2.6.20:
http://kernel.org/pub/linux/kernel/people/bart/ide-2.6.20.patch

Result: incompilable kernel! Reason is the following hunk:

99,113d98
< diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
< index dad9c47..5a5c565 100644
< --- a/drivers/ide/ide-probe.c
< +++ b/drivers/ide/ide-probe.c
< @@ -1000,10 +1000,6 @@ static int ide_init_queue(ide_drive_t *drive)
<  	/* needs drive->queue to be set */
<  	ide_toggle_bounce(drive, 1);
<  
< -	/* enable led activity for disk drives only */
< -	if (drive->media == ide_disk && hwif->led_act)
< -		blk_queue_activity_fn(q, hwif->led_act, drive);
< -
<  	return 0;
<  }
<  

Would you please care for proper patch sets in future, just for efficiency reasons?

Side note: One diode of my TEAC CDRW54 (/dev/hdd) flickers every 2 seconds.
That's normal and it does not do any harm.


I ripped out this hunk and applied the resulting patch
collection with parameter -R against 2.6.20.
Results:
a. compilable kernel 
b. SUCCESS after endless hours of testing!


3 conclusions from that:

1. The buggy code responsible for the horrible reinitialization
and drive seek errors with my TEAC CDRW54 as /dev/hdd
is proven to reside in the patch collection mentioned above.
In so far kernel 2.6.20 urgently needs another reversion (sigh)!


2. The crap code responsible for the terrible system hangups I
reported (no mouse, no keyboard, no screen - even more horrible
than a Windoze virus) definitely resides in kernel 2.6.21 rc1 or 2.


It needs 3 things to find that out:
a. lots of time
b. patience
c. a machine running about 10 hours as it does not happen immediately.
Fact is: This hangup does not happen working with 2.6.20.


3. Linus should slow down the kernel release speed for the following
3 reasons:
a. The speed is discouraging possible testers because things are going too fast
b. The output of that publishing speed is nothing but half mature crap
b. 2.6.20 has proven to be a never ending story as far as regressions
are concerned! Why? Almost every week a new release candidate - insane!
7 weeks for fixing regressions - and still no end in sight!
Proposal: 2 weeks per release candidate, 2,5 to 3 months for an official kernel.



To help you which hunks need to be reversed in official 2.6.20 please see
the 6 outline attachments: 2 dmesg, 2 lspci-vvvxxx, 2 diffs.
As the revised 2.6.20 kernel works without trouble I did not compile
2.6.19. The 6 texts should be helpful though to get this issue fixed.
And I hope that this is the definte last regression of that horrible kernel.

Thanks everybody

Uwe

P. S.: Andrew, if you want me to test 2.6.21-rc2-mm1 I have 2 questions:

1. When should I do this if I see myself running after endless regressions
in official kernel releases? All you can is demand!

2. Why aren't my linuxtv contributions at least part of the mm-tree?
Cooperation shouldn't be a one way street, should it?
And please stop telling me stories about some Mr. Chehab or anybody else,
as my two contributions are fine and I don't feel responsible for
some mismatch gatekeepers @ linuxtv.org! Fact is: I do my best to
contribute whatever I can and they simply ignore it, which is imbearable!

-- 
"Feel free" - 5 GB Mailbox, 50 FreeSMS/Monat ...
Jetzt GMX ProMail testen: www.gmx.net/de/go/mailfooter/promail-out

Re: Bugs in kernels 2.6.20 plus 2.6.21 rc1 and 2

From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: 2007-03-09 21:57:42

Hi,

On Friday 09 March 2007, Uwe Bugla wrote:
Hello Bart, hello everybody,

As requested I applied the following patch with parameter -R against 2.6.20:
http://kernel.org/pub/linux/kernel/people/bart/ide-2.6.20.patch

Result: incompilable kernel! Reason is the following hunk:

99,113d98
< diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
< index dad9c47..5a5c565 100644
< --- a/drivers/ide/ide-probe.c
< +++ b/drivers/ide/ide-probe.c
< @@ -1000,10 +1000,6 @@ static int ide_init_queue(ide_drive_t *drive)
<  	/* needs drive->queue to be set */
<  	ide_toggle_bounce(drive, 1);
<  
< -	/* enable led activity for disk drives only */
< -	if (drive->media == ide_disk && hwif->led_act)
< -		blk_queue_activity_fn(q, hwif->led_act, drive);
< -
<  	return 0;
<  }
<  

Would you please care for proper patch sets in future, just for efficiency reasons?
Doh, I missed the chunk of the block layer patch, sorry for that.
Side note: One diode of my TEAC CDRW54 (/dev/hdd) flickers every 2 seconds.
That's normal and it does not do any harm.


I ripped out this hunk and applied the resulting patch
collection with parameter -R against 2.6.20.
Results:
a. compilable kernel 
b. SUCCESS after endless hours of testing!
2.6.20 "good" kernel has newer build date then the "bad" 2.6.20.1
test kernel (with the IDE patchset reversed)?
3 conclusions from that:

1. The buggy code responsible for the horrible reinitialization
and drive seek errors with my TEAC CDRW54 as /dev/hdd
is proven to reside in the patch collection mentioned above.
Nope, unfortunately this only proves that all 2.6.20 changes modulo IDE
changes doesn't seem to cause the problems.  "Unfortunately" because it
would be much easier for me to just find guilty change in the patchset,
take the blame and fix it :-) but...

There are only 6 changes in the patchset which influence the _code_ that
is used by your hardware/driver configuration and none seems to actually
influence the driver _behavior_ on your system:

* [PATCH] ide-cd: Handle strange interrupt on the Intel ESB2

	the quirk code is not executed on ICH4 chipset

* [PATCH] PIIX: remove check for broken MW DMA mode 0

	dead code removal

* [PATCH] PIIX/SLC90E66: PIO mode fallback fix

	not used on your hardware as both hdc and hdd use DMA modes

* [PATCH] remove blk_queue_activity_fn

	dead code removal

* ide: unregister idepnp driver on unload

	ide-pnp is not used on this system

* [PATCH] lockdep: fix ide/proc interaction

	shouldn't change anything - the code is executed only during
	device driver (ide-cd etc.) removal

Besides the PCI configuration for IDE chipset is the same for both kernels.

Something really fishy is going on here... I'm out of ideas for the moment.
Maybe except retesting 2.6.19 + ide-2.6.20.patch applied...

Thanks,
Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help