PATCH: quieten some IDE diagnostics we will be using much more

3 messages, 2 authors, 2004-08-16 · open the first message on its own page

PATCH: quieten some IDE diagnostics we will be using much more

From: Alan Cox <hidden>
Date: 2004-08-15 14:48:51

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.8-rc3/drivers/ide/ide-probe.c linux-2.6.8-rc3/drivers/ide/ide-probe.c
--- linux.vanilla-2.6.8-rc3/drivers/ide/ide-probe.c	2004-08-09 15:51:00.000000000 +0100
+++ linux-2.6.8-rc3/drivers/ide/ide-probe.c	2004-08-14 21:03:03.000000000 +0100
@@ -635,12 +680,11 @@
 	device_register(&hwif->gendev);
 }
 
-#ifdef CONFIG_PPC
 static int wait_hwif_ready(ide_hwif_t *hwif)
 {
 	int rc;
 
-	printk(KERN_INFO "Probing IDE interface %s...\n", hwif->name);
+	printk(KERN_DEBUG "Probing IDE interface %s...\n", hwif->name);
 
 	/* Let HW settle down a bit from whatever init state we
 	 * come from */
@@ -671,7 +715,6 @@
 	
 	return rc;
 }
-#endif
 
 /*
  * This routine only knows how to look for drive units 0 and 1
@@ -717,7 +760,6 @@
 
 	local_irq_set(flags);
 
-#ifdef CONFIG_PPC
 	/* This is needed on some PPCs and a bunch of BIOS-less embedded
 	 * platforms. Typical cases are:
 	 * 
@@ -738,8 +780,7 @@
 	 *  BenH.
 	 */
 	if (wait_hwif_ready(hwif))
-		printk(KERN_WARNING "%s: Wait for ready failed before probe !\n", hwif->name);
-#endif /* CONFIG_PPC */
+		printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n", hwif->name);
 
 	/*
 	 * Second drive should only exist if first drive was found,

Re: PATCH: quieten some IDE diagnostics we will be using much more

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2004-08-16 15:18:48

This PATCH is intermixed with PATCH: IDE - do spin up for all platforms ...

On Sunday 15 August 2004 16:46, Alan Cox wrote:
quoted hunk
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.8-rc3/drivers/ide/ide-probe.c
linux-2.6.8-rc3/drivers/ide/ide-probe.c ---
linux.vanilla-2.6.8-rc3/drivers/ide/ide-probe.c	2004-08-09
15:51:00.000000000 +0100 +++
linux-2.6.8-rc3/drivers/ide/ide-probe.c	2004-08-14 21:03:03.000000000 +0100
@@ -635,12 +680,11 @@
 	device_register(&hwif->gendev);
 }

-#ifdef CONFIG_PPC
 static int wait_hwif_ready(ide_hwif_t *hwif)
 {
 	int rc;

-	printk(KERN_INFO "Probing IDE interface %s...\n", hwif->name);
+	printk(KERN_DEBUG "Probing IDE interface %s...\n", hwif->name);

 	/* Let HW settle down a bit from whatever init state we
 	 * come from */
@@ -671,7 +715,6 @@

 	return rc;
 }
-#endif

 /*
  * This routine only knows how to look for drive units 0 and 1
@@ -717,7 +760,6 @@

 	local_irq_set(flags);

-#ifdef CONFIG_PPC
 	/* This is needed on some PPCs and a bunch of BIOS-less embedded
 	 * platforms. Typical cases are:
 	 *
@@ -738,8 +780,7 @@
 	 *  BenH.
 	 */
 	if (wait_hwif_ready(hwif))
-		printk(KERN_WARNING "%s: Wait for ready failed before probe !\n",
hwif->name); -#endif /* CONFIG_PPC */
+		printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n",
hwif->name);

 	/*
 	 * Second drive should only exist if first drive was found,

Re: PATCH: quieten some IDE diagnostics we will be using much more

From: Alan Cox <hidden>
Date: 2004-08-16 15:31:38

On Mon, Aug 16, 2004 at 05:14:40PM +0200, Bartlomiej Zolnierkiewicz wrote:
This PATCH is intermixed with PATCH: IDE - do spin up for all platforms ...
See previous comment.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help