Thread (4 messages) 4 messages, 2 authors, 2004-07-02

Re: [PATCH] ide-taskfile.c fixups/cleanups part #2 [1/9]

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2004-07-02 16:38:24
Also in: lkml

On Friday 02 of July 2004 14:20, Pavel Machek wrote:
Hi!
Hi,
quoted
diff -puN drivers/ide/ide-taskfile.c~ide_tf_pio_out_fixes
drivers/ide/ide-taskfile.c ---
linux-2.6.7-bk11/drivers/ide/ide-taskfile.c~ide_tf_pio_out_fixes	2004-06-
28 21:15:54.030210376 +0200 +++
linux-2.6.7-bk11-bzolnier/drivers/ide/ide-taskfile.c	2004-06-28
21:15:54.035209616 +0200 @@ -409,6 +409,10 @@ ide_startstop_t
task_out_intr (ide_drive
 	if (!OK_STAT(stat = hwif->INB(IDE_STATUS_REG), DRIVE_READY,
drive->bad_wstat)) { return DRIVER(drive)->error(drive, "task_out_intr",
stat);
 	}
+
+	if (((stat & DRQ_STAT) == 0) ^ !rq->current_nr_sectors)
+		return DRIVER(drive)->error(drive, __FUNCTION__, stat);
+
Looks pretty close to obfuscated c code contents... Can't you use !=
wrrr...
or kill ! in second clause and use == or something?
								Pavel
is

	if (((stat & DRQ_STAT) != 0) ^ (rq->current_nr_sectors != 0))

better?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help