At Fri, 20 Feb 2004 16:25:42 +0100,
Bartlomiej Zolnierkiewicz wrote:

On Friday 20 of February 2004 13:28, Yoshinori Sato wrote:

quoted

At Thu, 19 Feb 2004 17:34:49 +0100,

Bartlomiej Zolnierkiewicz wrote:

quoted

Hi,

Can you send updated patch?
I am lost in incremental changes. :-)

Thanks.

Difference with linux-2.6.3.

Hi,

Your patch lacks Kconfig entries for CONFIG_H8300_IDE_{BASE,ALT,IRQNO}
and they are not present in kernel 2.6.3?

It is not done merge yet.
I compound it with other corrections and will submit it.
 

Are you aware that you can't build kernel which will support both controllers?
Not an issue if you can't build kernel which supports both this boards. :-)

I cleaned up patch a bit, changelog:
- h8max_ide.c and aki3068_ide.c merged into ide-h8300.c

Because there is a target different in implementation, 
correspondence becomes easy separated.

- added #if !defined(__H8300H__) to ide-proc.c
  (only place where ->OUTL is used, ->INL is unused in generic IDE code)

"__H8300S__" becomes the same condition, too.

- __ide_outl() and __ide_inl() removed 
- redundant includes removed 
- init driver through initcall (so no need to make changes in ide.c)

It seems to have been overwritten with default_hwif_iops 
setting of h8300_hwif_iops in module_init.
 

Not tested et all, I don't know whether it compiles. :-)

-- 
Yoshinori Sato
[off-list ref]