From: Biju Das <biju.das.jz@bp.renesas.com> Date: 2021-06-11 16:56:43
RZ/G2L i2c controller is compatible with RZ/A i2c controller.
By default IP is in reset state, so need to perform release
reset before accessing any register.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-riic.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
Hi Biju,
On Fri, Jun 11, 2021 at 6:56 PM Biju Das [off-list ref] wrote:
RZ/G2L i2c controller is compatible with RZ/A i2c controller.
By default IP is in reset state, so need to perform release
reset before accessing any register.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Please fill in .data, to avoid relying implicitly on RIIC_RZ_A being zero.
{ /* Sentinel */ },
};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
From: Philipp Zabel <p.zabel@pengutronix.de> Date: 2021-06-14 13:27:50
Hi Biju,
On Fri, 2021-06-11 at 17:56 +0100, Biju Das wrote:
quoted hunk
RZ/G2L i2c controller is compatible with RZ/A i2c controller.
By default IP is in reset state, so need to perform release
reset before accessing any register.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-riic.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
Hi Philipp,
On Mon, Jun 14, 2021 at 3:27 PM Philipp Zabel [off-list ref] wrote:
On Fri, 2021-06-11 at 17:56 +0100, Biju Das wrote:
quoted
RZ/G2L i2c controller is compatible with RZ/A i2c controller.
By default IP is in reset state, so need to perform release
reset before accessing any register.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-riic.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
There's no need for this. The reset API defines inline stubs so this can
be compiled without RESET_CONTROLLER enabled.
AFAIK, the issue is that RIIC on RZ/G2L requires reset support,
so it must be enabled when building a kernel for RZ/G2L.
As RZ/A does not need or use it, and may run from SRAM, I'd like to
leave it disabled when building a kernel not including RZ/G2L support.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
From: Biju Das <biju.das.jz@bp.renesas.com> Date: 2021-06-14 16:05:00
Hi Geert,
Thanks for the feedback.
-----Original Message-----
Subject: Re: [PATCH 3/5] i2c: riic: Add RZ/G2L support
Hi Biju,
On Fri, Jun 11, 2021 at 6:56 PM Biju Das [off-list ref]
wrote:
quoted
RZ/G2L i2c controller is compatible with RZ/A i2c controller.
By default IP is in reset state, so need to perform release reset
before accessing any register.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Please fill in .data, to avoid relying implicitly on RIIC_RZ_A being zero.
quoted
{ /* Sentinel */ },
};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
m68k.org
In personal conversations with technical people, I call myself a hacker.
But when I'm talking to journalists I just say "programmer" or something
like that.
-- Linus Torvalds
From: Biju Das <biju.das.jz@bp.renesas.com> Date: 2021-06-14 17:20:15
Hi Philipp,
Thanks for the review.
Subject: Re: [PATCH 3/5] i2c: riic: Add RZ/G2L support
Hi Biju,
On Fri, 2021-06-11 at 17:56 +0100, Biju Das wrote:
quoted
RZ/G2L i2c controller is compatible with RZ/A i2c controller.
By default IP is in reset state, so need to perform release reset
before accessing any register.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-riic.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)