Thread (7 messages) 7 messages, 4 authors, 2025-01-23

RE: [PATCH] scsi: storvsc: Set correct data length for sending SCSI command without payload

From: Long Li <longli@microsoft.com>
Date: 2025-01-23 03:08:53
Also in: linux-scsi, lkml

quoted
SCSI mid layer may send commands to lower driver without initializing private
data.
quoted
For example, scsi_send_eh_cmnd() may send TEST_UNIT_READY and
REQUEST_SENSE to lower layer driver without initializing private data.
Right. Thanks for pointing out this path that I wasn't aware of. My suggestion
would be to add a little more detail in the commit message, including identifying
this path where the private data isn't zero'ed. Some future developer will wonder
what's going on and appreciate having the specific reason provided.
I sent v2 adding more details to the comment.

Long
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help