2 messages, 2 authors, 2021-06-16 · open the first message on its own page
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Date: 2021-06-16 02:25:21
Michael,
As general cleanup and in preparation for subsequent patches:
Applied 1-3 to 5.14/scsi-staging. Since Hannes' series has deprecated status_byte() and CHECK_CONDITION I had to tweak that portion. Please verify my conflict resolution. Thanks! -- Martin K. Petersen Oracle Linux Engineering
From: Michael Kelley <hidden>
Date: 2021-06-16 19:54:43
From: Martin K. Petersen <martin.petersen@oracle.com> Sent: Tuesday, June 15, 2021 7:25 PM
Michael,quoted
As general cleanup and in preparation for subsequent patches:Applied 1-3 to 5.14/scsi-staging. Since Hannes' series has deprecated status_byte() and CHECK_CONDITION I had to tweak that portion. Please verify my conflict resolution.
Unfortunately, it's not quite right. The line of code in question needs to be if ((vstor_packet->vm_srb.scsi_status & 0xFF) == SAM_STAT_CHECK_CONDITION && The status_byte() helper was doing the masking as well as the right shift, so the masking will need to be open coded. The replacement get_status_byte() helper won't work here because it's based on a scsi_cmnd structure. Michael