RE: [PATCH] HID: hyperv: NULL check before some freeing functions is not needed.
From: Michael Kelley <hidden>
Date: 2020-02-29 20:20:11
Also in:
linux-input, lkml
From: Lucas Tanure <redacted> Sent: Saturday, February 29, 2020 9:30 AM
Fix below warnings reported by coccicheck: drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Lucas Tanure <redacted>
Reviewed-by: Michael Kelley <redacted>
quoted hunk ↗ jump to hunk
--- drivers/hid/hid-hyperv.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c index dddfca555df9..0b6ee1dee625 100644 --- a/drivers/hid/hid-hyperv.c +++ b/drivers/hid/hid-hyperv.c@@ -193,8 +193,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev*input_device, goto cleanup; /* The pointer is not NULL when we resume from hibernation */ - if (input_device->hid_desc != NULL) - kfree(input_device->hid_desc); + kfree(input_device->hid_desc); input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC); if (!input_device->hid_desc)@@ -207,8 +206,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev*input_device, } /* The pointer is not NULL when we resume from hibernation */ - if (input_device->report_desc != NULL) - kfree(input_device->report_desc); + kfree(input_device->report_desc); input_device->report_desc = kzalloc(input_device->report_desc_size, GFP_ATOMIC); -- 2.25.1