[PATCH v2] hwmon: (amc6821) sign extension temperature

Subsystems: hardware monitoring, the rest

STALE3608d

2 messages, 2 authors, 2016-11-19 · open the first message on its own page

[PATCH v2] hwmon: (amc6821) sign extension temperature

From: Matt Weber <hidden>
Date: 2016-11-19 04:21:15

From: Jared Bents <redacted>

Converts the unsigned temperature values from the i2c read
to be sign extended as defined in the datasheet so that
negative temperatures are properly read.

Signed-off-by: Jared Bents <redacted>
Signed-off-by: Matt Weber <redacted>
---
v1 -> v2
 - checkpatch cleanup, removed space between cast
   and function call.  truncated line over 80chars

---
 drivers/hwmon/amc6821.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
index 12e851a..eb53e0b 100644
--- a/drivers/hwmon/amc6821.c
+++ b/drivers/hwmon/amc6821.c
@@ -188,7 +188,8 @@ static struct amc6821_data *amc6821_update_device(struct device *dev)
 			!data->valid) {
 
 		for (i = 0; i < TEMP_IDX_LEN; i++)
-			data->temp[i] = i2c_smbus_read_byte_data(client,
+			data->temp[i] = (int8_t)i2c_smbus_read_byte_data(
+				client,
 				temp_reg[i]);
 
 		data->stat1 = i2c_smbus_read_byte_data(client,
-- 
1.9.1

Re: [v2] hwmon: (amc6821) sign extension temperature

From: Guenter Roeck <linux@roeck-us.net>
Date: 2016-11-19 16:25:20

On Fri, Nov 18, 2016 at 10:20:38PM -0600, Matt Weber wrote:
From: Jared Bents <redacted>

Converts the unsigned temperature values from the i2c read
to be sign extended as defined in the datasheet so that
negative temperatures are properly read.

Signed-off-by: Jared Bents <redacted>
Signed-off-by: Matt Weber <redacted>
Applied.

Guenter
quoted hunk
---
v1 -> v2
 - checkpatch cleanup, removed space between cast
   and function call.  truncated line over 80chars

---
 drivers/hwmon/amc6821.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
index 12e851a..eb53e0b 100644
--- a/drivers/hwmon/amc6821.c
+++ b/drivers/hwmon/amc6821.c
@@ -188,7 +188,8 @@ static struct amc6821_data *amc6821_update_device(struct device *dev)
 			!data->valid) {
 
 		for (i = 0; i < TEMP_IDX_LEN; i++)
-			data->temp[i] = i2c_smbus_read_byte_data(client,
+			data->temp[i] = (int8_t)i2c_smbus_read_byte_data(
+				client,
 				temp_reg[i]);
 
 		data->stat1 = i2c_smbus_read_byte_data(client,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help