Thread (14 messages) 14 messages, 4 authors, 2021-12-20

Re: [PATCH v3 4/5] gpio: msc313: Add support for SSD201 and SSD202D

From: Daniel Palmer <hidden>
Date: 2021-12-20 15:19:02
Also in: linux-arm-kernel, lkml

Hi Bartosz,

On Mon, 20 Dec 2021 at 23:50, Bartosz Golaszewski [off-list ref] wrote:
On Mon, Dec 13, 2021 at 10:40 AM Daniel Palmer [off-list ref] wrote:
quoted
This adds GPIO support for the SSD201 and SSD202D chips.

Signed-off-by: Daniel Palmer <redacted>
Reviewed-by: Linus Walleij <redacted>
---
I applied patches 1-3. This triggers a bunch of checkpatch errors.
Please address them and resend this single patch.
The warnings about complex macros being wrapped in parentheses when
the things it's complaining about are defined lists not macros?
Not going to say I know better than checkpatch but I think the errors
there are wrong. Putting parentheses around the lists would break the
arrays they get put into.

Cheers,

Daniel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help