Hi Andy,

quoted

quoted

quoted

quoted

+/* FIRST register:
+ *   0: MUX
+ *   1: GPIO/IOP
+ *   2: No change
+ */

For all comments starting from here and for similar cases elsewhere:
 - why it is not in kernel doc?
 - what the value that add?
(Some of them so cryptic or so obvious)

The comment explains usage of 'enum mux_f_mg'
The 'enum' is only used in the driver.
It helps programmers to remember or look-up the define of the enum.
Need we add this kind of comment to kernel doc?

Why not?

Does the kerenl doc mean dt-binding document?

If not, could you pleae tell me where should I put the kernel document?
Any references for pinctrl drivers?

Can I add more comments for the enum in c file, instead of creating new
kernel doc?



Best regards,

Wells Lu

Smart Computing Program
Home Entertainment Business Unit
Sunplus Technology Co., Ltd.
19, Innovation 1st Road,
Science-based Industrial Park
Hsin-Chu, Taiwan 300
TEL：886-3-5786005 ext. 2580