# Re: \[PATCH v4 02/15\] gpio: regmap: set gpio\_chip of\_node

- From: Michael Walle \<hidden\>
- Date: 2021-03-04 17:25:56 
- List: linux-gpio
- Page: https://ratatoskr.run/linux-gpio/2021/03/6288569
- Thread: https://ratatoskr.run/linux-gpio/2021/03/6287993/t.md

```text
Am 2021-03-04 17:46, schrieb Andy Shevchenko:
> On Thu, Mar 4, 2021 at 6:33 PM Andy Shevchenko
> [ref] wrote:
>> On Thu, Mar 4, 2021 at 5:44 PM Álvaro Fernández Rojas [ref] wrote:
>
> Let me summarize what we can do this independently on any of my
> patches and be okay with.
>
> In the regmap GPIO configuration you supply struct fwnode_handle *fwnode.
> You can you fwnode API in the actual GPIO controller driver.
> Inside gpio-regmap simply do this for now
>
> gc->of_node = to_of_node(config->fwnode);

If doing so, can we please have a comment saying that config->fwnode
might be NULL in which case the fwnode of the parent is used?

> The last part is an amendment I have told about, but it can be done
> later on by switching the entire GPIO chip to use fwnode instead of
> of_node.

-- 
-michael
```
