On Wed, Feb 10, 2021 at 10:30 AM Joe Perches [off-list ref] wrote:

On Tue, 2021-02-09 at 23:49 -0800, Drew Fustini wrote:

quoted

-     debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,
+     debugfs_create_file("pinctrl-devices", 0400,
                          debugfs_root, NULL, &pinctrl_devices_fops);

NAK.  You've changed the permission levels.

NAK is usually given when the whole idea is broken. Here is not the
case and you may have helped to amend the patch.

...

And you have to keep the S_IFREG or'd along with the octal.

Perhaps time to read the code?
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L387

...

checkpatch does this conversion using this command line:

$ ./scripts/checkpatch.pl -f --show-types --terse drivers/pinctrl/*.[ch] --types=SYMBOLIC_PERMS --fix-inplace

NAK! See above.

-       debugfs_create_file("pins", S_IFREG | S_IRUGO,
+       debugfs_create_file("pins", S_IFREG | 0444,
                            device_root, pctldev, &pinctrl_pins_fops);

-- 
With Best Regards,
Andy Shevchenko