Re: [libgpiod][PATCH 6/6] core: add the kernel uapi header to the repository
From: Andy Shevchenko <hidden>
Date: 2021-01-11 13:46:40
From: Andy Shevchenko <hidden>
Date: 2021-01-11 13:46:40
On Mon, Jan 11, 2021 at 3:37 PM Bartosz Golaszewski [off-list ref] wrote:
From: Bartosz Golaszewski <redacted> In order to avoid any problems with symbols missing from the host linux kernel headers (for example: if current version of libgpiod supports features that were added recently to the kernel but the host headers are outdated and don't export required symbols) let's add the uapi header to the repository and include it instead of the one in /usr/include/linux.
I doubt this is a good decision. First of all if the host (or rather target, because host should not influence build of libgpiod) has outdated header it may be for a reason (it runs old kernel). When you run new library on outdated kernel it might produce various of interesting errors (in general, I haven't investigated libgpiod case). On top of that you make a copy'n'paste source code which is against the Unix way. Sorry, but I'm in favour of dropping this one. -- With Best Regards, Andy Shevchenko