[PATCH] gpio/gpio-mxs : Unmap region obtained by of_iomap

Subsystems: gpio subsystem, the rest

STALE3597d

2 messages, 2 authors, 2016-10-10 · open the first message on its own page

[PATCH] gpio/gpio-mxs : Unmap region obtained by of_iomap

From: Arvind Yadav <hidden>
Date: 2016-10-05 09:39:59

Free memory mapping, if mxs_gpio_probe is not successful.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/gpio/gpio-mxs.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
index b9daa0b..ee17248 100644
--- a/drivers/gpio/gpio-mxs.c
+++ b/drivers/gpio/gpio-mxs.c
@@ -308,8 +308,10 @@ static int mxs_gpio_probe(struct platform_device *pdev)
 	writel(~0U, port->base + PINCTRL_IRQSTAT(port) + MXS_CLR);
 
 	irq_base = irq_alloc_descs(-1, 0, 32, numa_node_id());
-	if (irq_base < 0)
-		return irq_base;
+	if (irq_base < 0) {
+		err = irq_base;
+		goto out_iounmap;
+	}
 
 	port->domain = irq_domain_add_legacy(np, 32, irq_base, 0,
 					     &irq_domain_simple_ops, NULL);
@@ -349,6 +351,8 @@ out_irqdomain_remove:
 	irq_domain_remove(port->domain);
 out_irqdesc_free:
 	irq_free_descs(irq_base, 32);
+out_iounmap:
+	iounmap(port->base);
 	return err;
 }
 
-- 
1.7.9.5

Re: [PATCH] gpio/gpio-mxs : Unmap region obtained by of_iomap

From: Linus Walleij <hidden>
Date: 2016-10-10 08:49:14

On Wed, Oct 5, 2016 at 11:38 AM, Arvind Yadav [off-list ref] wrote:
Free memory mapping, if mxs_gpio_probe is not successful.

Signed-off-by: Arvind Yadav <redacted>
Patch applied.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help