# Re: \[PATCH v2 3/3\] mm/gup: Remove try\_get\_page(), call try\_get\_compound\_head() directly

- From: John Hubbard \<jhubbard@nvidia.com\>
- Date: 2021-08-12 18:19:09 
- List: linux-fsdevel
- Page: https://ratatoskr.run/linux-fsdevel/2021/08/212260
- Thread: https://ratatoskr.run/linux-mm/2021/08/212074/t.md

```text
On 8/12/21 2:22 AM, Christoph Hellwig wrote:
> On Wed, Aug 11, 2021 at 12:05:42AM -0700, John Hubbard wrote:
>> -		if (unlikely(!try_get_page(page)))
>> +		if (unlikely(try_get_compound_head(page, 1) == NULL))
>
> Why not a simple ! instead of the == NULL?

I'll fix those up and post a v4.

>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>

Thanks for the reviews!


thanks,
-- 
John Hubbard
NVIDIA
```
