On 11/21/19 12:08 AM, Christoph Hellwig wrote:

On Wed, Nov 20, 2019 at 11:13:36PM -0800, John Hubbard wrote:

quoted

+static int pin_goldfish_pages(unsigned long first_page,
+			      unsigned long last_page,
+			      unsigned int last_page_size,
+			      int is_write,
+			      struct page *pages[MAX_BUFFERS_PER_COMMAND],
+			      unsigned int *iter_last_page_size)

Why not goldfish_pin_pages?  Normally we put the module / subsystem
in front.

Heh, is that how it's supposed to go?  Sure, I'll change it. :)

Also can we get this queued up for 5.5 to get some trivial changes
out of the way?

Is that a question to Andrew, or a request for me to send this as a
separate patch email (or both)?


thanks,
-- 
John Hubbard
NVIDIA