[PATCH 5/6] Squashfs: fix f_pos check in get_dir_index_using_offset

DORMANTno replies

From: Phillip Lougher <hidden>
Date: 2012-03-10 02:54:37
Also in: lkml
Subsystem: filesystems (vfs and infrastructure), squashfs file system, the rest · Maintainers: Alexander Viro, Christian Brauner, Phillip Lougher, Linus Torvalds

One off error in the f_pos check.  If f_pos is 3 or less don't
bother reading the index because we're at the start of the
directory, and we obviously already know where that is on disk.

This eliminates an unnecessary read.

Signed-off-by: Phillip Lougher <phillip@squashfs.org.uk>
---
 fs/squashfs/dir.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c
index bbd3864..100b01b 100644
--- a/fs/squashfs/dir.c
+++ b/fs/squashfs/dir.c
@@ -64,7 +64,7 @@ static int get_dir_index_using_offset(struct super_block *sb,
 	 * is offset by 3 because we invent "." and ".." entries which are
 	 * not actually stored in the directory.
 	 */
-	if (f_pos < 3)
+	if (f_pos <= 3)
 		return f_pos;
 	f_pos -= 3;
 
-- 
1.7.5.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help