[PATCH] dlm & gfs2: use sysfs

STALE7200d

2 messages, 2 authors, 2007-01-26 · open the first message on its own page

[PATCH] dlm & gfs2: use sysfs

From: Randy Dunlap <hidden>
Date: 2007-01-26 02:56:19

From: Randy Dunlap <redacted>

With CONFIG_DLM=m, CONFIG_PROC_FS=n, and CONFIG_SYSFS=n, kernel build
fails with:

WARNING: "kernel_subsys" [fs/gfs2/locking/dlm/lock_dlm.ko] undefined!
WARNING: "kernel_subsys" [fs/dlm/dlm.ko] undefined!
WARNING: "kernel_subsys" [fs/configfs/configfs.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Since fs/dlm/lockspace.c and fs/gfs2/locking/dlm/sysfs.c use
kernel_subsys, they should either DEPEND on it or SELECT it.

Signed-off-by: Randy Dunlap <redacted>
---
 fs/dlm/Kconfig  |    1 +
 fs/gfs2/Kconfig |    1 +
 2 files changed, 2 insertions(+)
--- linux-2620-rc6.orig/fs/dlm/Kconfig
+++ linux-2620-rc6/fs/dlm/Kconfig
@@ -5,6 +5,7 @@ config DLM
 	tristate "Distributed Lock Manager (DLM)"
 	depends on IPV6 || IPV6=n
 	select CONFIGFS_FS
+	select SYSFS
 	select IP_SCTP if DLM_SCTP
 	help
 	A general purpose distributed lock manager for kernel or userspace
--- linux-2620-rc6.orig/fs/gfs2/Kconfig
+++ linux-2620-rc6/fs/gfs2/Kconfig
@@ -38,6 +38,7 @@ config GFS2_FS_LOCKING_DLM
 	select IP_SCTP if DLM_SCTP
 	select CONFIGFS_FS
 	select DLM
+	select SYSFS
 	help
 	Multiple node locking module for GFS2
 

Re: [PATCH] dlm & gfs2: use sysfs

From: Steven Whitehouse <hidden>
Date: 2007-01-26 12:05:01

Hi,

Now in the GFS2 -nmw git tree. Thanks,

Steve.

On Thu, 2007-01-25 at 18:42 -0800, Randy Dunlap wrote:
quoted hunk
From: Randy Dunlap <redacted>

With CONFIG_DLM=m, CONFIG_PROC_FS=n, and CONFIG_SYSFS=n, kernel build
fails with:

WARNING: "kernel_subsys" [fs/gfs2/locking/dlm/lock_dlm.ko] undefined!
WARNING: "kernel_subsys" [fs/dlm/dlm.ko] undefined!
WARNING: "kernel_subsys" [fs/configfs/configfs.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Since fs/dlm/lockspace.c and fs/gfs2/locking/dlm/sysfs.c use
kernel_subsys, they should either DEPEND on it or SELECT it.

Signed-off-by: Randy Dunlap <redacted>
---
 fs/dlm/Kconfig  |    1 +
 fs/gfs2/Kconfig |    1 +
 2 files changed, 2 insertions(+)
--- linux-2620-rc6.orig/fs/dlm/Kconfig
+++ linux-2620-rc6/fs/dlm/Kconfig
@@ -5,6 +5,7 @@ config DLM
 	tristate "Distributed Lock Manager (DLM)"
 	depends on IPV6 || IPV6=n
 	select CONFIGFS_FS
+	select SYSFS
 	select IP_SCTP if DLM_SCTP
 	help
 	A general purpose distributed lock manager for kernel or userspace
--- linux-2620-rc6.orig/fs/gfs2/Kconfig
+++ linux-2620-rc6/fs/gfs2/Kconfig
@@ -38,6 +38,7 @@ config GFS2_FS_LOCKING_DLM
 	select IP_SCTP if DLM_SCTP
 	select CONFIGFS_FS
 	select DLM
+	select SYSFS
 	help
 	Multiple node locking module for GFS2
 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help