strcpy() is deprecated for use on fixed-size buffers. Replace it with
strscpy() to avoid potential buffer overflow issues.
Found by checkpatch.pl:
WARNING: Prefer strscpy over strcpy
Signed-off-by: yuebingkun <redacted>
---
drivers/video/fbdev/platinumfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: David Laight <hidden> Date: 2026-08-17 14:38:02
On Mon, 17 Aug 2026 11:18:16 +0800
yuebingkun [off-list ref] wrote:
strcpy() is deprecated for use on fixed-size buffers. Replace it with
strscpy() to avoid potential buffer overflow issues.
There is no point using strscpy() to copy quoted strings into arrays.
Indeed, if the string is too long the kernel build will fail if strcpy()
is used but strscpy() will silently truncate the strings.
So strscpy() is actually worse here.
There are plenty of places where the destination size isn't known.
Which might be worth fixing.
David
quoted hunk
Found by checkpatch.pl:
WARNING: Prefer strscpy over strcpy
Signed-off-by: yuebingkun <redacted>
---
drivers/video/fbdev/platinumfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
There is no point using strscpy() to copy quoted strings into arrays.
Indeed, if the string is too long the kernel build will fail if strcpy()
is used but strscpy() will silently truncate the strings.
So strscpy() is actually worse here.
Thank you for the explanation. You are right, for copying a known
string literal into a fixed-size array, strcpy() is actually safer
because the compiler can catch overflow at build time. I will drop
this patch.
---
There is no point using strscpy() to copy quoted strings into arrays.
Indeed, if the string is too long the kernel build will fail if strcpy()
is used but strscpy() will silently truncate the strings.
So strscpy() is actually worse here.
Thank you for the explanation. You are right, for copying a known
string literal into a fixed-size array, strcpy() is actually safer
because the compiler can catch overflow at build time. I will drop
this patch.
---