# Re: \[PATCH 13/13\] lib/fonts: Remove internal symbols and macros from public header file

- From: Thomas Zimmermann \<tzimmermann@suse.de\>
- Date: 2026-03-02 13:45:32 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2026/03/3435519
- Thread: https://ratatoskr.run/linux-fbdev/2026/02/3417506/t.md

```text


Am 23.02.26 um 16:05 schrieb Helge Deller:
> On 2/18/26 09:16, Thomas Zimmermann wrote:
>> diff --git a/include/linux/font.h b/include/linux/font.h
>> index 4ff956a1cd0a..6e9a4c93b47b 100644
>> --- a/include/linux/font.h
>> +++ b/include/linux/font.h
>> @@ -92,20 +92,12 @@ struct font_desc {
>>   #define FONT6x8_IDX    12
>>   #define TER10x18_IDX    13
>>   -extern const struct font_desc    font_vga_8x8,
>> -            font_vga_8x16,
>> -            font_pearl_8x8,
>> -            font_vga_6x11,
>> -            font_7x14,
>> -            font_10x18,
>> -            font_sun_8x16,
>> -            font_sun_12x22,
>> -            font_acorn_8x8,
>> -            font_mini_4x6,
>> -            font_6x10,
>> -            font_ter_16x32,
>> -            font_6x8,
>> -            font_ter_10x18;
>> +#if defined(CONFIG_FONT_8x8)
>> +extern const struct font_desc font_vga_8x8;
>> +#endif
>> +#if defined(CONFIG_FONT_8x16)
>> +extern const struct font_desc font_vga_8x16;
>> +#endif
>
> I suggest not to use all those #ifdef(CONFIG_XXX) in the header files.
> They are not necessary, and trigger a rebuild of a whole lot C-files
> in case one single CONFIG option is changed.
> Instead use it in the C-files only.
> That way (re-)compilation is faster and you still get a link/build error
> when a symbol is used although the config option is not set.

Ok. I'll send out an update in a bit.

>
>> diff --git a/lib/fonts/font.h b/lib/fonts/font.h
>> new file mode 100644
>> index 000000000000..00f65a3da5c2
>> --- /dev/null
>> +++ b/lib/fonts/font.h
>> @@ -0,0 +1,52 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +
>> +#ifndef _LIB_FONTS_FONT_H
>> +#define _LIB_FONTS_FONT_H
>> +
>> +#include <linux/font.h>
>> +
>> +#if defined(CONFIG_FONT_PEARL_8x8)
>> +extern const struct font_desc font_pearl_8x8;
>> +#endif
>> +#if defined(CONFIG_FONT_6x11)
>> +extern const struct font_desc font_vga_6x11;
>> +#endif
> ...
> same here...
>
> Helge
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)


```
