# \[PATCH\] fbdev: fix fb\_pad\_unaligned\_buffer mask

- Subsystems: FRAMEBUFFER LAYER, FRAMEBUFFER CORE, THE REST
- Maintainers: Helge Deller, Simona Vetter, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2026/01/3389784/t

## \[PATCH\] fbdev: fix fb\_pad\_unaligned\_buffer mask

- From: Osama Abdelkader \<hidden\>
- Date: 2026-01-27 19:31:09 
- Message: https://ratatoskr.run/linux-fbdev/2026/01/3389784.md

```text
mask is u8, so it should use 0xff instead of 0xfff
Signed-off-by: Osama Abdelkader <redacted>
---
 drivers/video/fbdev/core/fbmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index eff757ebbed1..cf199038f069 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -100,7 +100,7 @@ EXPORT_SYMBOL(fb_pad_aligned_buffer);
 void fb_pad_unaligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 idx, u32 height,
 				u32 shift_high, u32 shift_low, u32 mod)
 {
-	u8 mask = (u8) (0xfff << shift_high), tmp;
+	u8 mask = (u8) (0xff << shift_high), tmp;
 	int i, j;
 
 	for (i = height; i--; ) {
-- 
2.43.0

```

## Re: \[PATCH\] fbdev: fix fb\_pad\_unaligned\_buffer mask

- From: Helge Deller \<deller@gmx.de\>
- Date: 2026-01-27 20:47:31 
- Message: https://ratatoskr.run/linux-fbdev/2026/01/3389852.md

```text
On 1/27/26 20:30, Osama Abdelkader wrote:
> mask is u8, so it should use 0xff instead of 0xfff
> Signed-off-by: Osama Abdelkader <redacted>
> ---
>   drivers/video/fbdev/core/fbmem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

applied.

Thanks!
Helge
```