# Re: \[PATCH 2/5\] backlight: qcom-wled: Support ovp values for PMI8950

- From: Konrad Dybcio \<hidden\>
- Date: 2026-01-07 14:05:41 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2026/01/3356633
- Thread: https://ratatoskr.run/dri-devel/2026/01/3356582/t.md

```text
On 1/7/26 2:31 PM, Barnabás Czémán wrote:
> WLED4 found in PMI8950 supports different ovp values.
> 
> Fixes: 10258bf4534bf ("backlight: qcom-wled: Add PMI8950 compatible")
> Signed-off-by: Barnabás Czémán <redacted>
> ---

[...]

>  	case 4:
> -		u32_opts = wled4_opts;
> -		size = ARRAY_SIZE(wled4_opts);
> +		if (of_device_is_compatible(dev->of_node, "qcom,pmi8950-wled")) {
> +			u32_opts = pmi8950_wled4_opts;
> +			size = ARRAY_SIZE(pmi8950_wled4_opts);
> +		} else {
> +			u32_opts = wled4_opts;
> +			size = ARRAY_SIZE(wled4_opts);
> +		}

I really don't like how this driver went about abstracting parsing
all of that, but that's not your fault

Reviewed-by: Konrad Dybcio <redacted>

Konrad
```