# Re: \[PATCH v3 3/4\] fbdev: omapfb: Make FB\_DEVICE dependency optional

- From: Andy Shevchenko \<hidden\>
- Date: 2025-12-30 11:37:09 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2025/12/3348750
- Thread: https://ratatoskr.run/linux-fbdev/2025/12/3348412/t.md

```text
On Mon, Dec 29, 2025 at 09:28:21PM -0800, Chintan Patel wrote:
> omapfb provides several sysfs interfaces for framebuffer configuration
> and debugging, but these are not required for the core driver.
> 
> Remove the hard dependency on CONFIG_FB_DEVICE and make sysfs support
> optional by using dev_of_fbinfo() to obtain the backing device at runtime.
> When FB_DEVICE is disabled, sysfs operations are skipped while the code
> still builds and is type-checked.

...

> +		struct device *dev = dev_of_fbinfo(fbdev->fbs[i]);

Still the same issue I pointed out in v2 review.

>  		int t;
> +
> +		if (!dev)
> +			continue;

...

> +		struct device *dev = dev_of_fbinfo(fbdev->fbs[i]);
> +
> +		if (!dev)
> +			continue;

Ditto.

-- 
With Best Regards,
Andy Shevchenko


```
